[TMVA][Python] Fix feature name handling for RBDT::LoadText#20565
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Nov 28, 2025
Merged
[TMVA][Python] Fix feature name handling for RBDT::LoadText#20565guitargeek merged 1 commit intoroot-project:masterfrom
RBDT::LoadText#20565guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
1 task
guitargeek
force-pushed
the
issue-20267
branch
from
35fb390 to
bfd8a32
Compare
If the XGBoost model encodes feature names, they will also be used in the `.txt` dump of the model. We have to use these names in `RBDT::LoadTxt` as well, so that the `.txt` file can be read correctly without errors. The RBDT unit test is also updated to cover this case of custom feature names, which happens when the training data comes from a pandas DataFrame. Also implement some suggestions by ruff. Closes root-project#20267.
guitargeek
force-pushed
the
issue-20267
branch
from
bfd8a32 to
3a6bbde
Compare
vepadulano
approved these changes
Nov 28, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
The changes LGTM, thanks! Please merge only once the tests are green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the XGBoost model encodes feature names, they will also be used in the
.txtdump of the model. We have to use these names inRBDT::LoadTxtas well, so that the.txtfile can be read correctly without errors.The RBDT unit test is also updated to cover this case of custom feature names, which happens when the training data comes from a pandas DataFrame.
Closes #20267. Credit goes to @jlidrych for the solution.