[v638][TMVA][Python] Fix feature name handling for RBDT::LoadText#20568
Merged
guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom Nov 28, 2025
Merged
[v638][TMVA][Python] Fix feature name handling for RBDT::LoadText#20568guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom
RBDT::LoadText#20568guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom
Conversation
If the XGBoost model encodes feature names, they will also be used in the `.txt` dump of the model. We have to use these names in `RBDT::LoadTxt` as well, so that the `.txt` file can be read correctly without errors. The RBDT unit test is also updated to cover this case of custom feature names, which happens when the training data comes from a pandas DataFrame. Also implement some suggestions by ruff. Closes root-project#20267. (cherry picked from commit 8c83c8f)
guitargeek
requested review from
bellenot,
dpiparo and
lmoneta
as code owners
guitargeek
merged commit 85c7ba8
into
root-project:v6-38-00-patches
25 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20565