[test] Activate test otherwise never executed#20752
[test] Activate test otherwise never executed#20752dpiparo merged 1 commit intoroot-project:masterfrom
Conversation
Test Results 21 files 21 suites 3d 20h 21m 53s ⏱️ Results for commit 56a8af5. ♻️ This comment has been updated with latest results. |
| MACROARG \"abc;xyz\" | ||
| OUTREF semicolon.ref | ||
| LABELS roottest regression cling) | ||
| if(NOT MSVC) # See #20738 |
There was a problem hiding this comment.
Thanks for being honest here and explicitly deactivating the test on Windows!
You could have hidden this fact by relying on the automatic deactivation of all tests that have .sh in the command on Windows 🙂
https://github.com/root-project/roottest/blame/master/cmake/modules/RoottestMacros.cmake#L1076
By the way @bellenot, I think it would give us a clearer picture on what tests are run on Windows when looking at the CMake code if we would not do these kind of hidden checks. But maybe that's preference.
There was a problem hiding this comment.
By the way @bellenot, I think it would give us a clearer picture on what tests are run on Windows when looking at the CMake code if we would not do these kind of hidden checks. But maybe that's preference.
Well, that was a short solution, instead of adding if(NOT MSVC) for every test using shell scripts, gnu make, and any other unsupported feature...
But I can indeed revisit the remaining ones at some point, and even possibly port some of them on Windows...
There was a problem hiding this comment.
That would be awesome 🎈
|
@dpiparo Could this be ported to 6-38-patches? |
4 participants
Fixes #20738