Skip to content

[test] Activate test otherwise never executed #20752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Dec 18, 2025
Merged

[test] Activate test otherwise never executed #20752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions roottest/cling/parsing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ ROOTTEST_ADD_TEST(runTTestClass
DEPENDS ${GENERATE_DICTIONARY_TEST}
LABELS roottest regression cling)

ROOTTEST_ADD_TEST(semicolon
MACRO semicolon.C
MACROARG \"abc;xyz\"
OUTREF semicolon.ref
LABELS roottest regression cling)
if(NOT MSVC) # See #20738
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being honest here and explicitly deactivating the test on Windows!

You could have hidden this fact by relying on the automatic deactivation of all tests that have .sh in the command on Windows 🙂

https://github.com/root-project/roottest/blame/master/cmake/modules/RoottestMacros.cmake#L1076

By the way @bellenot, I think it would give us a clearer picture on what tests are run on Windows when looking at the CMake code if we would not do these kind of hidden checks. But maybe that's preference.

Copy link
Copy Markdown
Member

@bellenot bellenot Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way @bellenot, I think it would give us a clearer picture on what tests are run on Windows when looking at the CMake code if we would not do these kind of hidden checks. But maybe that's preference.

Well, that was a short solution, instead of adding if(NOT MSVC) for every test using shell scripts, gnu make, and any other unsupported feature...
But I can indeed revisit the remaining ones at some point, and even possibly port some of them on Windows...

Copy link
Copy Markdown
Contributor

@guitargeek guitargeek Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome 🎈

ROOTTEST_ADD_TEST(thesemicolon
COPY_TO_BUILDDIR semicolon.C ./thesemicolon.sh
COMMAND ./thesemicolon.sh
OUTREF semicolon.ref
LABELS roottest regression cling)
endif()

ROOTTEST_ADD_TEST(assertManipulators
MACRO assertManipulators.C
Expand Down
3 changes: 3 additions & 0 deletions roottest/cling/parsing/thesemicolon.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#! /usr/bin/env sh

root.exe -b -l -q semicolon.C\(\"abc\ \;\ xyz\"\)
Loading