[xml] prevent files parsing from root folder#21812
Merged
linev merged 4 commits intoroot-project:masterfrom Apr 9, 2026
Merged
[xml] prevent files parsing from root folder#21812linev merged 4 commits intoroot-project:masterfrom
linev merged 4 commits intoroot-project:masterfrom
Conversation
silverweed
reviewed
Apr 7, 2026
linev
force-pushed
the
xml_warnings
branch
3 times, most recently
from
cbd1c51 to
23f5c6e
Compare
Test Results 22 files 22 suites 3d 4h 59m 58s ⏱️ Results for commit 6d837af. ♻️ This comment has been updated with latest results. |
Check using `std::filesystem::proximate` functionality
When file cannot be opened - do not try to parse it, just print failure And print correctly error when string is parsing
Such string parsing also can include access to local xml files
dpiparo
reviewed
Apr 8, 2026
dpiparo
approved these changes
Apr 8, 2026
Use of parent or top directory paths are not allowed So control proper error messages in the output
Member
Author
|
/backport to 6.38, 6.36, 6.32, 6.30, 6.28, 6.26 |
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing xml file,
TXMLEnginecan include other files via syntax:So prevent inclusion of files which are not in current directory or sub-directory.
Check extra in windows that file name does not starts with drive letter like 'C:filename.ext'
Add correspondent tests to
roottest/root/io/xmlfolder