Skip to content

[6.32] [xml] prevent files parsing from parent folder#21856

Merged
linev merged 3 commits intoroot-project:v6-32-00-patchesfrom
linev:xml_632
Apr 9, 2026
Merged

[6.32] [xml] prevent files parsing from parent folder#21856
linev merged 3 commits intoroot-project:v6-32-00-patchesfrom
linev:xml_632

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Apr 9, 2026

Backport of #21812

linev added 2 commits April 9, 2026 07:59
Check using `std::filesystem::proximate` functionality
When file cannot be opened - do not try to parse it, just print failure
And print correctly error when string is parsing
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test Results

     6 files       6 suites   20h 14m 30s ⏱️
 2 562 tests  2 562 ✅ 0 💤 0 ❌
14 957 runs  14 957 ✅ 0 💤 0 ❌

Results for commit 958d41a.

♻️ This comment has been updated with latest results.

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Apr 9, 2026

The alma8, i.e. gcc 8.5, build is likely to be fixed if the stdc++fs library is linked. The switch should be -lstdc++fs and should be conditionally added on linux and if gcc version <=8.

@linev linev requested a review from bellenot as a code owner April 9, 2026 09:09
@linev
Copy link
Copy Markdown
Member Author

linev commented Apr 9, 2026

Yes, I found several such places in ROOT cmake files. Let see if helps.

@linev linev merged commit 8a03871 into root-project:v6-32-00-patches Apr 9, 2026
8 of 9 checks passed
@linev linev deleted the xml_632 branch April 9, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants