[math] migrate old Makefiles to CMake and reenable non-covered tests#21890
Open
ferdymercury wants to merge 21 commits intoroot-project:masterfrom
Open
[math] migrate old Makefiles to CMake and reenable non-covered tests#21890ferdymercury wants to merge 21 commits intoroot-project:masterfrom
ferdymercury wants to merge 21 commits intoroot-project:masterfrom
Conversation
ferdymercury
changed the title
ferdymercury
force-pushed
the
smatrix
branch
2 times, most recently
from
0dda18e to
fe7101c
Compare
Test Results 22 files 22 suites 3d 16h 57m 9s ⏱️ For more details on these failures, see this check. Results for commit 29c8d58. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Apr 12, 2026
linev
requested changes
Apr 13, 2026
Member
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
There are three points in smatrix/test/ subdirectory:
- Do we need test reflex dictionaries
- Is linking with CLHEP library crucial, do it properly
- How to use old ROOT files stored in the directory
Collaborator
Author
No idea whether those things are relevant, I just reenabled something that was there. If not relevant, we should just delete the whole test :) |
ferdymercury
commented
Apr 13, 2026
ferdymercury
commented
Apr 14, 2026
ferdymercury
commented
Apr 14, 2026
ferdymercury
commented
Apr 14, 2026
pcanal
reviewed
Apr 14, 2026
ferdymercury
commented
Apr 15, 2026
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Apr 23, 2026
ROOT_genreflex_CMD is used everywhere not ROOT_genreflex_cmd Found out while investigating failures in root-project#21890
Collaborator
Author
|
re-enabled scripts reading preexisting .ROOT files plot this: 
|
dpiparo
pushed a commit
that referenced
this pull request
Apr 24, 2026
ROOT_genreflex_CMD is used everywhere not ROOT_genreflex_cmd Found out while investigating failures in #21890
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
as suggested by linev Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com> [test] rescue reflex_use
rm debug print capital try fix genreflex not found on mac
fix indices and read testOp, copy header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split-off #21820 as requested by @pcanal and @linev