[roottest] fix typo in variable name#22031
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Apr 24, 2026
Merged
Conversation
ROOT_genreflex_CMD is used everywhere not ROOT_genreflex_cmd Found out while investigating failures in root-project#21890
pcanal
reviewed
Apr 23, 2026
| endif() | ||
| set(ROOT_genreflex_cmd ${ROOT_BINDIR}/genreflex) | ||
| set(ROOT_genreflex_CMD ${ROOT_BINDIR}/genreflex) |
Member
There was a problem hiding this comment.
Note we should probably see if we can now remove the duplicate (former main) settings:
roottest/CMakeLists.txt: set(ROOT_genreflex_CMD ${ROOTSYS}/bin/genreflex.exe CACHE INTERNAL "ROOTTEST variable for genreflex executable")
roottest/CMakeLists.txt: set(ROOT_genreflex_CMD ${ROOTSYS}/bin/genreflex CACHE INTERNAL "ROOTTEST variable for genreflex executable")
Collaborator
Author
There was a problem hiding this comment.
They are used for different things, so not easily:
- A: one is for macros, only used when you call
REFLEX_GENERATE_DICTIONARYor, from within roottest, when you callROOTTEST_GENERATE_REFLEX_DICTIONARY. This variant uses ROOT_BIN_DIR - B: the other one is for manual commands within roottests such as
COMMAND ${ROOT_genreflex_CMD} ${CMAKE_CURRENT_SOURCE_DIR}/abc.h -o. This variant uses ROOTSYS.
So two questions:
- should there be an if-else in version A) so that it resolves to genreflex.exe in Windows? Or maybe something more modern like using
$<TARGET_FILE:tgt>? - should we replace
ROOTTEST_ADD_TEST(5594 COMMAND ${ROOT_genreflex_CMD} ${CMAKE_CURRENT_SOURCE_DIR}/AliAODPid.h -o AliAODPid.cxx --select=${CMAKE_CURRENT_SOURCE_DIR}/AliAODPid_selection.xml)
with sth like:
ROOTTEST_GENERATE_REFLEX_DICTIONARY(AliAODPid.h SELECTION AliAODPid_selection.xml)
to avoid those duplicities of the CMD definition?
Maybe in a follow-up PR ?
Tagging also @guitargeek since he has dealt with ROOTSYS removal.
Collaborator
Author
pcanal
approved these changes
Apr 23, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (although we may want to take care of the duplicate setting)
Test Results 22 files 22 suites 3d 11h 21m 22s ⏱️ For more details on these failures, see this check. Results for commit 4f148f1. ♻️ This comment has been updated with latest results. |
Member
|
/backport to 6.40 |
|
This PR has been backported to branch 6.40: #22037 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROOT_genreflex_CMD is used everywhere
not ROOT_genreflex_cmd
Found out while investigating failures in #21890