Skip to content

[Math] Remove ROOT::Math::digamma() function#21970

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:digamma
Apr 20, 2026
Merged

[Math] Remove ROOT::Math::digamma() function#21970
guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek:digamma

Conversation

@guitargeek
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek commented Apr 20, 2026

This function was introduced about 2 years ago in #16747 as a quick fix to make LnGamma differentiable with Clad, but it was inconvenient because it depended on the external GSL library.

Since vgvassilev/clad#1733, Clad natively implements a digamma function, so we can use this one now that we updated to Clad 2.3.

This function was introduced about 2 years ago as a quick fix to make
`LnGamma` differentiable with Clad, but it was inconvenient because it
depended on the external GSL library.

Since vgvassilev/clad#1733, Clad natively
implements a `digamma` function, so we can use this one now that we
updated to Clad 2.3.
Copy link
Copy Markdown
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guitargeek guitargeek merged commit 9b012a8 into root-project:master Apr 20, 2026
29 of 32 checks passed
@guitargeek guitargeek deleted the digamma branch April 20, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants