[RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor#22065
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Apr 26, 2026
Merged
[RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor#22065guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
Follows up on fa97774, which ensures that the mutation of the computation graphs operation mode is is only happening during minimization. There was a remnant `setOperMode(RooAbsArg::ADirty)` in the evaluator constructor that can now be removed.
Test Results 22 files 22 suites 3d 8h 51m 0s ⏱️ For more details on these failures, see this check. Results for commit e44bf78. |
dpiparo
approved these changes
Apr 26, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on fa97774, which ensures that the mutation of the computation graphs operation mode is is only happening during minimization. There was a remnant
setOperMode(RooAbsArg::ADirty)in the evaluator constructor that can now be removed.This also fixes slowdowns in some tutorials that happened becuause some
setOperMode(RooAbsArg::ADirty)"leaked" to RooAbsArgs that were shared with other computation graphs, e.g. for plotting.