Skip to content

[RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor #22065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Apr 26, 2026
+0 −11
Merged

[RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor #22065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions roofit/roofitcore/src/RooFit/Evaluator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,17 +326,6 @@ void Evaluator::updateOutputSizes()
for (auto &info : _nodes) {
info.outputSize = outputSizeMap.at(info.absArg);
info.isDirty = true;
// We don't need dirty flag propagation because the evaluator takes care
// of deciding what needs to be re-evaluated. We can disable the regular
// dirty state propagation. However, fundamental variables like
// RooRealVars and RooCategories are usually shared with other
// computation graphs outside the evaluator, so they can't be mutated.
// See also the code of the RooMinimizer, which ensures that dirty state
// propagation is temporarily disabled during minimization to really
// eliminate any overhead from the dirty flag propagation.
if (!info.absArg->isFundamental()) {
setOperMode(info.absArg, RooAbsArg::ADirty);
}
}

if (_useGPU) {
Expand Down
Loading