[df bulk] Prepare for bulk nodes that update values #22479
Draft
vepadulano wants to merge 4 commits into
Draft
Conversation
Test Results 22 files 22 suites 3d 14h 27m 17s ⏱️ Results for commit 7506fd8. ♻️ This comment has been updated with latest results. |
Sets the stage for future bulk reading where the actual values that need to be passed to downstream nodes may need to get stored in a separate location.
vepadulano
force-pushed
the
df-bulk-prepare-node-update
branch
from
d33254e to
309b5ad
Compare
Nodes of the computation graph which may operate a selection on which entries are valid or not are modified to accommodate for multiple entries being evaluated at the same time. For now, the size of the bulk is set to one. Note that this commit does not touch in any way the reading of data.
The RLoopManager decides the current bulk size that all nodes of the computation graph must adhere to. Currently this is set to one, in the future it may vary.
define and variation nodes update their current available values via an Update method, this is now prepared to work in bulks, currently assuming always size one.
vepadulano
force-pushed
the
df-bulk-prepare-node-update
branch
from
309b5ad to
7506fd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #22313 #22461 #22472
define and variation nodes update their current available values via an Update method, this is now prepared to work in bulks, currently assuming always size one.
Part 4 of N of the dataframe bulk processing effort.