[df bulk] Prepare for reading TTreeReaderValue in bulks#22494
Draft
vepadulano wants to merge 5 commits into
Draft
[df bulk] Prepare for reading TTreeReaderValue in bulks#22494vepadulano wants to merge 5 commits into
vepadulano wants to merge 5 commits into
Conversation
Sets the stage for future bulk reading where the actual values that need to be passed to downstream nodes may need to get stored in a separate location.
Nodes of the computation graph which may operate a selection on which entries are valid or not are modified to accommodate for multiple entries being evaluated at the same time. For now, the size of the bulk is set to one. Note that this commit does not touch in any way the reading of data.
The RLoopManager decides the current bulk size that all nodes of the computation graph must adhere to. Currently this is set to one, in the future it may vary.
define and variation nodes update their current available values via an Update method, this is now prepared to work in bulks, currently assuming always size one.
This is a partial implementation, serving as a starting point. It only considers the case of reading from TTreeReaderValue. It also highlights already a few pre-existing features which may not be supported anymore: * Reading polymorphic TBranch with different concrete types stored across different events * Reading polymorphic TBranch of concrete types read as their base type
vepadulano
requested review from
bellenot,
dpiparo,
martamaja10 and
pcanal
as code owners
Test Results 22 files 22 suites 3d 15h 46m 40s ⏱️ For more details on these failures, see this check. Results for commit cda277f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #22313 #22461 #22472 #22479
This is a partial implementation, serving as a starting point. It only considers the case of reading from TTreeReaderValue. It also highlights already a few pre-existing features which may not be supported anymore:
Part 5 of N of the dataframe bulk processing effort.