[ntuple] Add RPageSinkS3 for the basic S3 write path (Mode B)#22653
Merged
Conversation
JasMehta08
requested review from
bellenot,
jblomer and
silverweed
as code owners
June 18, 2026 09:16
jblomer
reviewed
Jun 23, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Very nice! Some discussion points.
Test Results 23 files 23 suites 3d 14h 2m 3s ⏱️ Results for commit 0d1ad19. ♻️ This comment has been updated with latest results. |
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
June 24, 2026 04:45
55e94d8 to
5841fc3
Compare
jblomer
reviewed
Jun 25, 2026
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
June 28, 2026 06:49
5841fc3 to
5f33a1b
Compare
Contributor
|
We have some merge conflicts which need to be resolved first |
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
June 30, 2026 04:43
5f33a1b to
8adb1e0
Compare
Contributor
Author
|
I have resolved the conflicts |
jblomer
reviewed
Jul 2, 2026
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
July 2, 2026 17:00
8adb1e0 to
621a5d3
Compare
Contributor
Author
|
I have made the changes according to the comments please have a look |
jblomer
reviewed
Jul 6, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! For the Windows failures, the test should use gSystem's wrapper for setenv and unsetenv.
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
July 6, 2026 16:16
621a5d3 to
fbb28cd
Compare
Contributor
Author
|
I have fixed the issue with |
jblomer
approved these changes
Jul 8, 2026
silverweed
reviewed
Jul 9, 2026
silverweed
left a comment
silverweed
left a comment
Contributor
There was a problem hiding this comment.
Very nice work and sorry for the late review: I have a few comments but it looks good overall!
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
July 10, 2026 09:58
fbb28cd to
1c6c331
Compare
Contributor
Author
|
I went through the comments and made changes accordingly. Please let me know if I should change anything further. |
JasMehta08
force-pushed
the
ntuple-s3-sink
branch
from
July 10, 2026 13:37
1c6c331 to
0d1ad19
Compare
silverweed
approved these changes
Jul 10, 2026
Contributor
Author
|
Please have a look and let me know if I should change anything |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Adds
RPageSinkS3, the write path of the experimental S3 storage backend for RNTuple.Changes or fixes:
RPageSinkS3(Mode B full write path):InitImpl(header),CommitPageImpl/CommitSealedPageImpl(one S3 object per sealed page,kTypeObject64locator),StageClusterImpl,CommitClusterGroupImpl(page list), andCommitDatasetImpl(footer, then the JSON anchor written last for atomicity).Checklist: