Skip to content

[asan] Fix argv array for PyROOT applications #22768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bellenot merged 2 commits into from
Jul 8, 2026
+4 −2
Merged

[asan] Fix argv array for PyROOT applications #22768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a36efc
[asan] Fix argv array for PyROOT applications
bellenot Jul 7, 2026
2d2da10
clang-format
bellenot Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bindings/pyroot/pythonizations/src/RPyROOTApplication.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ bool PyROOT::RPyROOTApplication::CreateApplication(int ignoreCmdLineOpts)
char **argv = nullptr;

if (ignoreCmdLineOpts) {
argv = new char *[argc];
// Last argv must be null (see https://en.cppreference.com/cpp/language/main_function)
argv = new char *[argc + 1] {};
} else {
// Retrieve sys.argv list from Python
PyObject *argl = PySys_GetObject("argv");
Expand All @@ -57,7 +58,8 @@ bool PyROOT::RPyROOTApplication::CreateApplication(int ignoreCmdLineOpts)
argc = static_cast<int>(size);
}

argv = new char *[argc];
// Last argv must be null (see https://en.cppreference.com/cpp/language/main_function)
argv = new char *[argc + 1] {};

for (int i = 1; i < argc; ++i) {
PyObject *item = PyList_GetItem(argl, i);
Expand Down
Loading