Skip to content

[ntuple] fix RVec resize from small to large vector#22854

Merged
jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-rvec-resize
Jul 21, 2026
Merged

[ntuple] fix RVec resize from small to large vector#22854
jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-rvec-resize

Conversation

@jblomer

@jblomer jblomer commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Resizing needs to check if the previous buffer pointed to the small vector space before releasing the memory.

Needs backporting to 6.40 and 6.36.

Fixes #22855

@jblomer jblomer self-assigned this Jul 20, 2026
@jblomer
jblomer requested a review from silverweed as a code owner July 20, 2026 09:12
@jblomer
jblomer requested review from enirolf, hahnjo and pcanal July 20, 2026 09:12
Comment thread tree/ntuple/test/rfield_vector.cxx Outdated
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 13h 40m 16s ⏱️
 3 875 tests  3 875 ✅ 0 💤 0 ❌
75 080 runs  75 080 ✅ 0 💤 0 ❌

Results for commit d06ed89.

♻️ This comment has been updated with latest results.

@jblomer
jblomer force-pushed the ntuple-fix-rvec-resize branch 2 times, most recently from b7fa4ea to d06ed89 Compare July 20, 2026 19:25
Resizing needs to check if the previous buffer pointed to the small
vector space before releasing the memory.
@jblomer
jblomer requested a review from silverweed July 21, 2026 08:14

@hahnjo hahnjo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jblomer
jblomer merged commit 9f4a1ea into root-project:master Jul 21, 2026
34 of 35 checks passed
@jblomer
jblomer deleted the ntuple-fix-rvec-resize branch July 21, 2026 09:57
@jblomer

jblomer commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22854 to branch 6.40 requested by jblomer

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22866

@jblomer

jblomer commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.36

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22854 to branch 6.36 requested by jblomer

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.36: #22875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ntuple] double free when resizing small RVec

4 participants