[6.40] [RF] Fix implementation of RooGenericPdf/RooFormulaVar::binBoundaries()#22868
Merged
guitargeek merged 1 commit intoJul 21, 2026
Merged
Conversation
Follows up on 9ea4ec6, which got the implementation of `RooFormulaVar::binBoundaries()` and `RooGenericPdf::binBoundaries()` wrong. The limis passed to the `binBoundaries()` call should not be included in the returned `std::list<double>`. I was led to believe that including the query boundaries was necessary, because otherwise the numeric integrals didn't work, but I see now that this is actually a bug on the RooBinIntegrator side, which is now reported as root-project#22858. Also, implement a unit test that ensures the fixed implementation of `binBoundaries()` is consistent with the one of RooHistPdf and matches the expected values. Finally, move a remaining helper that was added in 9ea4ec6 from the public to the private interface (from RooHelpers.h to RooFitImplHelpers.h, which never gets installed). (cherry picked from commit 28b3942)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22859, requested by @guitargeek.