[RF][HS3] Fix RooFormulaVar key export#22882
Merged
Merged
Conversation
guitargeek
changed the title
Test Results 23 files 23 suites 3d 19h 55m 37s ⏱️ For more details on these failures, see this check. Results for commit 1b2e248. ♻️ This comment has been updated with latest results. |
This PR handles some key changes to HS3 missed by root-project#22735 Fix HS3 export type names for generic functions. `RooTFnBinding and generated transformation functions now export as `generic, while RooGenericPdf continues to use `generic_dist. Legacy `generic_function` files remain supported on import.
guitargeek
force-pushed
the
fix/hs3-generic-key
branch
from
July 25, 2026 16:49
46f08c6 to
1b2e248
Compare
guitargeek
approved these changes
Jul 25, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix!
Contributor
|
/backport to 6.40 |
|
Preparing to backport PR #22882 to branch 6.40 requested by guitargeek |
|
This PR has been backported to branch 6.40: #22918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
This PR handles some key changes to HS3 missed by #22735
Fix HS3 export type names for generic functions.
RooTFnBinding and generated transformation functions now export asgeneric, while RooGenericPdf continues to usegeneric_dist. Legacygeneric_function` files remain supported on import.Checklist: