Skip to content

[zip] check return value of R__memcompress, adjust R__zipOld - #22988

Merged
linev merged 6 commits into
root-project:masterfrom
linev:after_memcompress
Aug 3, 2026
Merged

[zip] check return value of R__memcompress, adjust R__zipOld#22988
linev merged 6 commits into
root-project:masterfrom
linev:after_memcompress

Conversation

@linev

@linev linev commented Aug 3, 2026

Copy link
Copy Markdown
Member
  1. In R__zipOld allocate dynamically bits_internal_state struct, use std::unique_ptr to simplify cleanup
  2. Return 0 in case of error from R__memcompress.
  3. Check return value of R__memcompress in all places where it used
  4. In THttpServer remove special handling of external civetweb; now R__memcompress can be called also with smaller stack

linev added 6 commits August 3, 2026 09:30
@linev
[http] remove workaround for R__memcompress
6ab5114 
Now use of external civetweb does not lead to failure in R__memcompress.
Therefore no need to disable compression with external civetweb
Also now is possible to move civetweb into builtins and use original cmake file for it
@linev
[zip] return 0 from R__memcompress when target buffer too small
5af6afc
@linev
[zip] allocate dynamically bits_internal_state in R__zipOld
c5c5b0b 
Use unique_ptr while code compiled with C++
Simplify release of the structure in case of failure
@linev
[http] check failure in R__memcompress
306b9dd 
If content of http request failed to compress,
request marked as failed and such result will be returned as reply to user
@linev
[json] return failure code when R__memcompress fails
c89551a
@linev
[gl] return empty vector when R__memcompress fails
d2f6b0f
@linev linev self-assigned this Aug 3, 2026
ferdymercury
ferdymercury approved these changes Aug 3, 2026
View reviewed changes

@ferdymercury ferdymercury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 18h 27m 36s ⏱️
 3 855 tests  3 854 ✅ 0 💤 1 ❌
79 425 runs  79 423 ✅ 1 💤 1 ❌

For more details on these failures, see this check.

Results for commit d2f6b0f.

pcanal
pcanal approved these changes Aug 3, 2026
View reviewed changes

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@linev
linev merged commit cdc23eb into root-project:master Aug 3, 2026
35 of 38 checks passed
@linev
linev deleted the after_memcompress branch August 3, 2026 16:15
@linev linev mentioned this pull request Aug 3, 2026
Merged
@ferdymercury ferdymercury mentioned this pull request Aug 4, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes
@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner
@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner
@couet couet Awaiting requested review from couet couet is a code owner
@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner
+1 more reviewer
@ferdymercury ferdymercury ferdymercury approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@linev linev

Labels

affects:master in:Core Libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linev @pcanal @ferdymercury