Fix an auto-registration problem in the FitPanel unit test - #22991
Merged
Conversation
Due to output redirection, failures in the fit panel unit tests were silent. Here, the output is shown in case of failure. Furthermore, the program silently crashed if a combo box couldn't select the desired entry. Now, the result of the combo box selection is checked, and an exception is thrown if the requested item is not present.
When object auto-registration is off, a TGraph2D was not displayed in the fit panel, because it is never drawn. This lead to a failure in gui tests.
hageboeck
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
August 3, 2026 11:11
1 task
Test Results 23 files 23 suites 3d 19h 24m 31s ⏱️ For more details on these failures, see this check. Results for commit ffc6f53. |
guitargeek
approved these changes
Aug 4, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank for fixing the auto-registration problem and improving the diagnostics in the unit test!
Member
Author
|
The red builds are the cpp11 container tests timing out, so this is unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #22817.
The unit tests for the fit panel were crashing when trying to select a TGraph2D that was never registered in the fit panel, because it was never drawn. Here, the output of the tests is made easier to interpret, and the graph is registered in
gDirectory, so the tests of the FitPanel can select it.