[cmake] Do not auto-turn OFF feature or auto-turn ON builtin_option - #23020
Open
ferdymercury wants to merge 1 commit into
Open
[cmake] Do not auto-turn OFF feature or auto-turn ON builtin_option#23020ferdymercury wants to merge 1 commit into
ferdymercury wants to merge 1 commit into
Conversation
ferdymercury
force-pushed
the
failondef2
branch
from
August 5, 2026 08:11
93f2ae0 to
442243a
Compare
ferdymercury
marked this pull request as ready for review
August 5, 2026 08:36
ferdymercury
commented
Aug 5, 2026
ferdymercury
commented
Aug 5, 2026
ferdymercury
commented
Aug 5, 2026
Test Results 23 files 23 suites 3d 18h 2m 16s ⏱️ For more details on these failures, see this check. Results for commit 98c555c. ♻️ This comment has been updated with latest results. |
for easy-to-install dependencies (via homebrew, apt-get) when dependency is missing in the system. Instead, force user to install it via package manager, or to turn feature purposely OFF. [nfc] improve error messages Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
ferdymercury
force-pushed
the
failondef2
branch
from
August 6, 2026 08:57
14f7899 to
98c555c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for easy-to-install dependencies (via homebrew, apt-get)
when dependency is missing in the system. Instead, force user to install it via package manager, or to turn feature purposely OFF by hand.
Spit-off from #23015 as suggested by @guitargeek
This goes totally in-line with what's already done for asimage, zlib, etc.