[6.30] [v636][cmake] Quote list-valued cache variable in root-config generation - #23033
Merged
pcanal merged 1 commit intoAug 6, 2026
Merged
Conversation
The loop that builds the `root-config --config` argument list guards each
cache variable with
if((var MATCHES "_(LIBRARIES|LIBRARY|INCLUDE|VERSION)") AND
(NOT ${${var}} STREQUAL "") AND
(NOT ${var} MATCHES "NOTFOUND"))
When the variable holds a list (e.g.
CLING_LIBRARIES=clingInterpreter;clingMetaProcessor;clingUtils) the
unquoted ${${var}} expands to several tokens, so the parenthesised
sub-expression `(NOT a b c STREQUAL "")` is malformed. CMake silently
accepted this until 4.4, which now propagates errors from parenthesised
if() sub-expressions (Kitware/CMake@240481490c, kitware/cmake#26424) and
fails configuration with "Unknown arguments specified".
Quote the expansion so the value is compared as a single string. Besides
fixing configuration with CMake >= 4.4, this restores the intended
behaviour: list-valued variables were previously dropped from
`root-config --config` (the malformed guard evaluated to false) and are
now included.
Signed-off-by: Chris Burr <christopher.burr@cern.ch>
(cherry picked from commit f8771bf)
Test Results 5 files 5 suites 16h 13m 35s ⏱️ For more details on these failures, see this check. Results for commit b66e369. |
Member
|
The one test failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23027, requested by @pcanal.