msvc specific link command

[xantares]

these are specific link options to be used only on a msvc host, won't work for a WIN32 mingw target for example

what does it do ? it seems it relinks the PyROOT library, with different options maybe ? isn't it something that could be achieved with cmake in a more generic way, by editing properties or flags ? also it seems its specific to arch ix86

[bellenot]

Thanks! I will apply it. And it is obviously specific to ix86, since x86_64 is not yet supported on Windows

[bellenot]

Thanks! Now applied in git master and v5-34-00-patches

[xantares]

@bellenot, I'd also like to understand why this command is here as i've got one other PR, #73 that may be related, regarding where to put this python module .pyd

[bellenot]

@xantares How could it be related? there is no /usr or /usr/local on Windows...

[xantares]

@bellenot but there's also a standard site dir, something like <python_prefix>\Lib\site-packages

[bellenot]

@xantares OK, but then this is another issue, not related to WIN32/MSVC (or did I miss something?)

[xantares]

i was wondering why this command was here instead of just setting the .pyd suffix, but I still do not understand bc9ce4e : was it to add -export:initlibPyROOT ? what's the use of ROOTULIBS ?

[bellenot]

@xantares OK, maybe ROOTULIBS is due to copy/paste. Will have to check

[bellenot]

@xantares In fact it is needed on Windows to force import of some symbols. It is used in v5-34-00-patches, but forgotten in master (since master doesn't build yet on Windows).

[xantares]

and what about the hard-wired link command ?

[bellenot]

No idea, I'll have to check with CMake/Python expert when he'll be back from vacation, but we are talking about #73, right?

[xantares]

yeah, i wasn't sure if changing the install destination of the PyROOT target would affect this .pyd too, because you relink it to libPyROOT.pyd somehow and reinstall it to CMAKE_INSTALL_BINDIR, and it seemed like overly-complicated to just set the .pyd suffix.