Move the preformat functionality to a separate crate#148
Merged
Conversation
TethysSvensson
force-pushed
the
tethys/preformat
branch
3 times, most recently
from
107220a to
d812dfc
Compare
TethysSvensson
force-pushed
the
tethys/preformat
branch
2 times, most recently
from
955c3fb to
e3f7aa3
Compare
Contributor
|
Other than a few nitpicks, this looks solid. I especially like simplifying the hook code. |
TethysSvensson
force-pushed
the
tethys/preformat
branch
from
d4c00aa to
6b96fd4
Compare
TethysSvensson
force-pushed
the
tethys/preformat
branch
from
6b96fd4 to
9ba75c4
Compare
TethysSvensson
added a commit
that referenced
this pull request
May 21, 2026
- examples/context_methods.rs: update stale `println!` label that still said "Using context_transform_nested():"; the code now uses clone + `context()`. Also updated the related `context_to()` comment. - rootcause-preformat/README.md: license links pointed at ../LICENSE-APACHE / ../LICENSE-MIT, which 404 once published. Use in-crate paths instead. - rootcause-preformat: add unit tests for `PreformatRootExt`, `ContextTransformNestedExt` (both `Report` and `Result` impls), and `PreformatAttachmentExt` (owned/ref/mut).
nicklaswj
pushed a commit
to nicklaswj/rootcause
that referenced
this pull request
May 21, 2026
…-rs#183) * Polish follow-up to rootcause-rs#148 (rootcause-preformat) - examples/context_methods.rs: update stale `println!` label that still said "Using context_transform_nested():"; the code now uses clone + `context()`. Also updated the related `context_to()` comment. - rootcause-preformat/README.md: license links pointed at ../LICENSE-APACHE / ../LICENSE-MIT, which 404 once published. Use in-crate paths instead. - rootcause-preformat: add unit tests for `PreformatRootExt`, `ContextTransformNestedExt` (both `Report` and `Result` impls), and `PreformatAttachmentExt` (owned/ref/mut). * cargo fmt
TethysSvensson
added a commit
to Kile-Asmussen/rootcause-work-fork
that referenced
this pull request
May 21, 2026
The Conversions sub-list in ResultExt mentioned a method (context_transform_nested) and a type (PreformattedContext) that live in the rootcause-preformat crate, not on ResultExt. Drop the bullet pointing at them and reshape the surviving context_to/context_transform entries into the same one-line-per-category style used by the rest of the list. Also add rootcause-preformat (introduced in rootcause-rs#148) to the Ecosystem list in the crate root, since the PR's own goal is to keep these overview lists in sync with what is actually implemented.
TethysSvensson
added a commit
to mkatychev/rootcause
that referenced
this pull request
May 21, 2026
- CHANGELOG: drop stale `display_preformatted`/`debug_preformatted` references and tighten the entry (those methods were removed in rootcause-rs#148). - `ReportAttachmentRef::format_inner_with_parent`: bring docs up to par with `format_inner` / `format_inner_unhooked`, including an example. - `AttachmentParent.attachment_index`: document the pre-sort, pre-filter convention that `DefaultReportFormatter` upholds. - `tests/attachment_parent.rs`: extend coverage to `Appendix` placement. - Rename the leftover `style1` binding to `style`.
yonas
pushed a commit
to yonasBSD/rootcause
that referenced
this pull request
May 26, 2026
…verview lists. (rootcause-rs#153) * Small changes * Fix broken intra-doc links and add rootcause-preformat to Ecosystem list The Conversions sub-list in ResultExt mentioned a method (context_transform_nested) and a type (PreformattedContext) that live in the rootcause-preformat crate, not on ResultExt. Drop the bullet pointing at them and reshape the surviving context_to/context_transform entries into the same one-line-per-category style used by the rest of the list. Also add rootcause-preformat (introduced in rootcause-rs#148) to the Ecosystem list in the crate root, since the PR's own goal is to keep these overview lists in sync with what is actually implemented. * Remove speculative "More to come" entry from Ecosystem list * Review nits: reorder ResultExt categories, drop duplicate ref, polish wording --------- Co-authored-by: Tethys Svensson <freaken@freaken.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC: @Kile-Asmussen