Polish follow-up to #148 (rootcause-preformat)#183
Merged
Conversation
- examples/context_methods.rs: update stale `println!` label that still said "Using context_transform_nested():"; the code now uses clone + `context()`. Also updated the related `context_to()` comment. - rootcause-preformat/README.md: license links pointed at ../LICENSE-APACHE / ../LICENSE-MIT, which 404 once published. Use in-crate paths instead. - rootcause-preformat: add unit tests for `PreformatRootExt`, `ContextTransformNestedExt` (both `Report` and `Result` impls), and `PreformatAttachmentExt` (owned/ref/mut).
TethysSvensson
force-pushed
the
worktree-preformat-followup
branch
from
e53b92b to
20a00a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish for #148:
examples/context_methods.rs: theprintln!label still said"Using context_transform_nested():"even though the code now usesclone +
context(). Updated the label and the relatedcontext_to()comment.
rootcause-preformat/README.md: license links pointed at../LICENSE-APACHE/../LICENSE-MIT. Switched to in-crate paths sothey resolve on crates.io / docs.rs.
rootcause-preformat: added unit tests forPreformatRootExt,ContextTransformNestedExt(bothReportandResultimpls), andPreformatAttachmentExt(owned / ref / mut).No external API change; no CHANGELOG entry.