🎨 PSR-12 coding standards, switch from PHPCS to Pint #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend switching to PER-CS which is the successor to PSR-12.
|
Member
Author
|
Looks like we'll have to bump to a minimum of PHP 8.1 in order to grab a Pint release that supports that, which I'm fine with. Thanks for the call out @vinkla 🙏 Might also reconsider the PHP minimum version bump here: roots/wordpress-core-installer#7 |
|
Another idea is to use PHP-CS-Fixer directly. The setup is similar to Pint, which is a wrapper library. You won't even have to use a config file if you only want it for checking pull requests. https://github.com/vinkla/extended-acf/blob/master/.github/workflows/php-cs-fixer.yml |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.