Add db open command with Playbook struct#100
Merged
Conversation
tangrufus
force-pushed
the
revert-90-revert-72-db-open
branch
8 times, most recently
from
8965890 to
cfde827
Compare
tangrufus
changed the title
db open command with Playbook structdb open command with Playbook struct
tangrufus
force-pushed
the
revert-90-revert-72-db-open
branch
2 times, most recently
from
f2ffae6 to
4fd83f3
Compare
tangrufus
force-pushed
the
revert-90-revert-72-db-open
branch
from
4fd83f3 to
3f32c62
Compare
swalkinshaw
reviewed
Feb 2, 2020
cmd/db_open_test.go
Outdated
| defer trellis.LoadFixtureProject(t)() | ||
|
|
||
| ui := cli.NewMockUi() | ||
| mockProject := &MockProject{detected: true} |
Member
There was a problem hiding this comment.
If you're using LoadFixtureProject you shouldn't need a mock project. The standard should work:
project := &trellis.Project{}
trellis := trellis.NewTrellis(project)That goes for the test below too
cmd/db_opener_factory.go
Outdated
| open(c DBCredentials) (err error) | ||
| } | ||
|
|
||
| func (f *DBOpenerFactory) make(app string, ui cli.Ui) (o DBOpener, err error) { |
cmd/db_opener_factory.go
Outdated
| type DBOpenerFactory struct{} | ||
|
|
||
| type DBOpener interface { | ||
| open(c DBCredentials) (err error) |
cmd/db_opener_factory.go
Outdated
| return nil, fmt.Errorf("%s is not supported", app) | ||
| } | ||
|
|
||
| func (f *DBOpenerFactory) getSupportedApps() []string { |
Member
Author
|
All set. Please review. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue #72 (which accidentally mereged and then reverted on #90)
Using
Playbookstruct from #91See: #7