Extract Playbook struct#91
Merged
tangrufus merged 7 commits intoroots:masterfrom Jan 21, 2020
tangrufus:playbook-struct
Merged
Conversation
swalkinshaw
reviewed
Jan 5, 2020
Member
swalkinshaw
left a comment
swalkinshaw
left a comment
There was a problem hiding this comment.
Looks great overall just had a few small comments
Member
|
Looks great 👍 I'll try and test soon |
swalkinshaw
reviewed
Jan 18, 2020
swalkinshaw
reviewed
Jan 18, 2020
swalkinshaw
reviewed
Jan 18, 2020
Member
|
Other than the one |
… & \`AdHocPlaybook\`; Remove \`PlaybookRunner.SetFiles\` #91 (comment) #91 (comment) #91 (comment)
swalkinshaw
approved these changes
Jan 20, 2020
swalkinshaw
reviewed
Jan 20, 2020
swalkinshaw
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #72 (comment)
Although all tests passed, need help on testing the commands manually to check for unwated (and not covered by tests) issues.