fix: switch course year tags without piling up browser history#261
Merged
Conversation
Course year tags used <Link> with default push navigation, so clicking through several years stacked a history entry per click and returning to the previous page required many Back clicks. Add `replace` so the URL stays shareable while a year switch replaces the current history entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bytmqtq2bNyot4PRvo8es7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rootulp
enabled auto-merge (squash)
July 17, 2026 21:51
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (2)
π WalkthroughWalkthroughCourse year links now replace the current browser-history entry when switching editions. A Playwright test verifies year URL updates and confirms one back navigation returns to the courses overview. ChangesCourse year navigation
Estimated code review effort: 2 (Simple) | ~10 minutes π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Reddit commenter noted that on a course page (e.g.
/courses/im703-wisconsin), clicking through the year tags stacks a browser-history entry per click, so returning to the previous page requires many Back clicks.The year tags used
<Link>with default push navigation. Addingreplacekeeps the URL shareable/bookmarkable while a year switch replaces the current history entry β so one Back returns to the previous page instead of stepping through each viewed year.Added an e2e test (
e2e/course-year-history.spec.ts) that clicks through several years and asserts a single Back returns to the courses overview.π€ Generated with Claude Code
https://claude.ai/code/session_01Bytmqtq2bNyot4PRvo8es7
Summary by CodeRabbit
Bug Fixes
Tests