fix: enable keyboard input on web client - #19
Conversation
mise.toml, gen_js_from_hbb.ts, message.ts, rendezvous.ts are all generated at build time and don't belong in source control.
Input source 1 (OS-level hooks) is unavailable in browsers, causing keyboard events to be silently dropped. Hardcode web to Input source 2 (Flutter key events) and remove the non-functional option from the UI.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe web bridge now supports only legacy and map keyboard modes, always reports Input source 2, and advertises only that source. The web JavaScript ignore file now excludes four repository-specific paths. ChangesKeyboard input source behavior
Web JavaScript ignore rules
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change enables keyboard input in the web client and removes a nonfunctional browser option; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
Summary
.gitignorefor generated JS build artifactsTest plan
Summary by CodeRabbit
Bug Fixes
Chores