Skip to content

Fix github.ref check for concurrency settings #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Fix github.ref check for concurrency settings #241

merged 1 commit into from
Aug 27, 2025

Conversation

@christophfroehlich
Copy link
Member

@christophfroehlich christophfroehlich commented Aug 27, 2025 •
edited
Loading

github.ref:

The ref given is fully-formed, meaning that for branches the format is refs/heads/<branch_name>.

which means the leading slash was wrong, see this canceled job for example.

https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#github-context

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Aug 27, 2025
@christophfroehlich christophfroehlich merged commit 294fc73 into master Aug 27, 2025
11 checks passed
@christophfroehlich christophfroehlich deleted the fix/concurrency branch August 27, 2025 12:19
mergify bot pushed a commit that referenced this pull request Aug 27, 2025
@christophfroehlich @mergify
Fix github.ref check for concurrency settings (#241)
6a2b4c5 
(cherry picked from commit 294fc73)
@mergify mergify bot mentioned this pull request Aug 27, 2025
Merged
mergify bot pushed a commit that referenced this pull request Aug 27, 2025
@christophfroehlich @mergify
Fix github.ref check for concurrency settings (#241)
a1ea16d 
(cherry picked from commit 294fc73)
@mergify mergify bot mentioned this pull request Aug 27, 2025
Merged
christophfroehlich pushed a commit that referenced this pull request Aug 27, 2025
@mergify
Fix github.ref check for concurrency settings (#241) (#242)
862280a
christophfroehlich pushed a commit that referenced this pull request Aug 27, 2025
@mergify
Fix github.ref check for concurrency settings (#241) (#243)
0264346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikishor saikishor saikishor approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@mhubii mhubii Awaiting requested review from mhubii

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees

No one assigned

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christophfroehlich @saikishor