Remove duplicate storage of i clamping #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
changed the base branch from
ros2-master
to
improve/pid/validation
|
|
christophfroehlich
force-pushed
the
improve/pid/validation
branch
from
98ed56d to
b419fc3
Compare
|
|
1 similar comment
|
|
christophfroehlich
force-pushed
the
remove/double/storage
branch
from
dfb701e to
286a487
Compare
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
christophfroehlich
force-pushed
the
remove/double/storage
branch
from
f62e10b to
36bba03
Compare
github-actions
bot
requested review from
LukasMacha97,
VX792,
bmagyar,
destogl,
erickisos,
fmauch and
moriarty
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ros2-master #512 +/- ##
===============================================
- Coverage 82.69% 82.67% -0.02%
===============================================
Files 29 29
Lines 1982 1980 -2
Branches 113 113
===============================================
- Hits 1639 1637 -2
Misses 274 274
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the duplicate storage of the limits, and left that one inside the antiwindup struct. (let's say that i-clamping is a poor-mans antiwindup strategy).