Skip to content

Conversation

saikishor
Copy link
Member

Change the constructor args to const ref instead of a copy

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (9b8eef6) to head (018d91a).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #513   +/-   ##
============================================
  Coverage        82.35%   82.35%           
============================================
  Files               29       29           
  Lines             1984     1984           
  Branches           114      114           
============================================
  Hits              1634     1634           
  Misses             281      281           
  Partials            69       69           
Flag Coverage Δ
unittests 82.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontrol_toolbox/include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Oct 14, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit b37cf44 into ros2-master Oct 14, 2025
27 of 28 checks passed
@christophfroehlich christophfroehlich deleted the change/const_ref branch October 14, 2025 14:59
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants