convert to sensor_msgs/BatteryState #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After merging this a kinetic release would be great to get the TurtleBot stacks going. |
Contributor
|
We should probably push this into a kinetic branch to avoid accidental releases and disturbing anyone who is using the sources on indigo with an api change. |
Contributor
|
@jihoonl do you still want to maintain this or would you like me to pick it up? |
Member
|
I can merge and releasing work. But other than that, it would be great if you can pick it up. |
Member
|
I couldn't do any extra activities so far because I don't have internet in home yet. 😢 |
Contributor
|
Created a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've standardized a new sensor_msgs/BatteryState this will switch to use it. I'd recommend releasing this into Kinetic but not backporting to indigo and jade.