Skip to content

Fix incorrect srv import (backport #88) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2025
+10 −10
Merged

Fix incorrect srv import (backport #88) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70276b4
Fix incorrect srv import (#88)
suchetanrs May 3, 2025
1f8e018
updated kilted CI (#89)
ahcorde May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@ on:
- ros2

jobs:
build_and_test_source_rolling:
build_and_test_source_kilted:
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-noble-latest
image: ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-ubuntu-noble-testing
steps:
- name: Build and run tests
id: action-ros-ci
uses: ros-tooling/action-ros-ci@v0.3
uses: ros-tooling/action-ros-ci@v0.4
with:
package-name: |
turtle_tf2_py
turtle_tf2_cpp
target-ros2-distro: rolling
vcs-repo-file-url: https://raw.githubusercontent.com/ros2/ros2/rolling/ros2.repos
target-ros2-distro: kilted
vcs-repo-file-url: https://raw.githubusercontent.com/ros2/ros2/kilted/ros2.repos
colcon-defaults: |
{
"build": {
Expand All @@ -32,19 +32,19 @@ jobs:
"pytest-args": ["-m", "not xfail"]
}
}
build_and_test_binaries_rolling:
build_and_test_binaries_kilted:
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-noble-latest
image: ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-ubuntu-noble-testing
steps:
- name: Build and run tests
id: action-ros-ci
uses: ros-tooling/action-ros-ci@v0.3
uses: ros-tooling/action-ros-ci@v0.4
with:
package-name: |
turtle_tf2_py
turtle_tf2_cpp
target-ros2-distro: rolling
target-ros2-distro: kilted
colcon-defaults: |
{
"build": {
Expand Down
2 changes: 1 addition & 1 deletion turtle_tf2_py/turtle_tf2_py/turtle_tf2_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from tf2_ros.buffer import Buffer
from tf2_ros.transform_listener import TransformListener

from turtlesim.srv import Spawn
from turtlesim_msgs.srv import Spawn


class FrameListener(Node):
Expand Down
Loading