Skip to content

Conversation

@mini-1235
Copy link
Contributor

I have encountered cases like moveit/moveit2#3599, where invalid XML syntax causes ros2 plugin list to hang and output errors like:

moveit_kinematics:
Traceback (most recent call last):
  File "/opt/ros/rolling/bin/ros2", line 33, in <module>
    sys.exit(load_entry_point('ros2cli==0.40.1', 'console_scripts', 'ros2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2cli/cli.py", line 91, in main
    rc = extension.main(parser=parser, args=args)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2plugin/command/plugin.py", line 37, in main
    return extension.main(args=args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2plugin/verb/list.py", line 68, in main
    tree = ET.parse(plugin_xml)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 1204, in parse
    tree.parse(source, parser)
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 569, in parse
    self._root = parser._parse_whole(source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 2, column 129

This PR makes the error easier to understand and unblock the rest of the packages

Failed to parse plugin XML file: /root/moveit_ws/install/moveit_kinematics/share/moveit_kinematics/cached_ik_kinematics_plugin_description.xml
XML error: not well-formed (invalid token): line 2, column 129

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Nov 18, 2025

Pulls: #285
Gist: https://gist.githubusercontent.com/ahcorde/24b265445ed9c134ff4889097fe386d6/raw/9c6dcf024488dd7e686708f5bebe000a3043b91e/ros2.repos
BUILD args: --packages-above-and-dependencies ros2plugin
TEST args: --packages-above ros2plugin
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17522

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 82475ee into ros:rolling Nov 19, 2025
3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Nov 19, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link

mergify bot commented Nov 19, 2025

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2025
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 82475ee)
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 82475ee)
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 82475ee)
ahcorde pushed a commit that referenced this pull request Nov 19, 2025
(cherry picked from commit 82475ee)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 20, 2025
(cherry picked from commit 82475ee)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 20, 2025
(cherry picked from commit 82475ee)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants