Fix assumption that CMAKE_INSTALL_*DIR paths are relative.#90
Merged
scpeters merged 1 commit intoros:rollingfrom Feb 6, 2026
Merged
Fix assumption that CMAKE_INSTALL_*DIR paths are relative.#90scpeters merged 1 commit intoros:rollingfrom
scpeters merged 1 commit intoros:rollingfrom
Conversation
This solution uses relative paths if possible, allowing the package to be relocatable, but still works correctly if CMAKE_INSTALL_*DIR paths are absolute. Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
scpeters
approved these changes
Feb 6, 2026
ahcorde
added a commit
that referenced
this pull request
Feb 9, 2026
…)" This reverts commit 6552c9d.
Contributor
|
@scpeters When merging PRs in the ros2 core we need to run the CI https://ci.ros2.org/job/ci_launcher/ or you can also run this script https://github.com/ros-tooling/ros-github-scripts |
ahcorde
added a commit
that referenced
this pull request
Feb 9, 2026
Contributor
|
sorry about that; I'll slow down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of #66 and #78, which fixes conflicts with latest
rolling.