Skip to content

Conversation

@jacobperron
Copy link
Contributor

When following install instructions for ros2-java, rosdep cannot resolve 'ament_pep8'.
Since we are not actually running any tests for this package, remove all test dependency declarations.

When following install instructions for ros2-java, rosdep cannot resolve 'ament_pep8'.
Since we are not actually running any tests for this package, remove all test dependency declarations.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron requested review from esteve and ivanpauno May 13, 2022 00:44
Copy link
Contributor

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


<test_depend>ament_copyright</test_depend>
<test_depend>ament_pep257</test_depend>
<test_depend>ament_pep8</test_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this package doesn't exist anymore, we're using ament_flake8 instead.

@jacobperron jacobperron merged commit c430324 into main May 13, 2022
@jacobperron jacobperron deleted the jacob/remove_unused_test_dependencies branch May 13, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants