update README.md for Android build on OSX#40
Merged
esteve merged 2 commits intoros2-java:masterfrom Jul 27, 2018
Merged
Conversation
Member
|
@qiao-tw wow, this is awesome, thanks! I was thinking that perhaps it'd be easier for users to have the instructions without any variables at all, like https://github.com/ros2/ros2/wiki/OSX-Development-Setup#build-the-ros-2-code However, I think it'd be really useful to put this in a script, what do you think? |
Contributor
Author
|
@esteve Sure, I agree, but where should this script locate? The 'ci-scripts' ? I'm afraid of breaking the CI though... |
Collaborator
|
I have jdk8 installed as well. |
esteve
approved these changes
Jul 27, 2018
Member
|
Sorry it's taken so long, I somehow thought it was already merged. Thanks for the patch and the patience! |
Contributor
Author
|
No problem! I'm glad to contribute! |
ivanpauno
pushed a commit
that referenced
this pull request
Apr 13, 2021
In these cases, we are likely leaking memory. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #38.
This change has been verified under OSX 10.13.4 and Ubuntu 16.04.