Remove Java compile flags #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves several compiler warnings. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
|
@jacobperron this makes the bytecode compliant with 1.6, so it can be used on Android, the warnings are harmless. Do you need any features available in 1.7? |
Contributor
Author
Nope. I wasn't aware of this requirement for Android. We can leave it as-is. |
Contributor
@esteve The main reason to remove the flags is just so we can get a "clean" build with modern Java (I'm using Java 11 here on Ubuntu 18.04). Because these flags are set, they:
How would you feel about only setting the Java 6 flags for the Android target? |
ivanpauno
pushed a commit
that referenced
this pull request
Apr 27, 2022
This fixes deprecation warnings at build time. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves several compiler warnings.