Add support for non standard point step sizes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Vahl <florian@flova.de>
Signed-off-by: Florian Vahl <florian@flova.de>
Signed-off-by: Florian Vahl <florian@flova.de>
|
Thanks for the fix! Could you please add a test to the tests file that verifies this does fix the issue? |
|
Thanks for your quick response @gbiggs! I added the test and it seems to solve the issue. |
gbiggs
approved these changes
Aug 1, 2022
|
CI:
|
|
Do you have an idea what's causing the tests to fail? The option manager traceback seems unrelated to the changes from this or. |
That's a separate issue that we are addressing in ros2/ci#675 |
|
Okay 👍 |
|
Another CI run:
|
|
Thanks for the contribution! |
gbiggs
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Remove reference to old impementation Signed-off-by: Florian Vahl <florian@flova.de> * Add support for non standard point step sizes Signed-off-by: Florian Vahl <florian@flova.de> * Fix code style Signed-off-by: Florian Vahl <florian@flova.de> * Add test Signed-off-by: Florian <florian@flova.de> Signed-off-by: Florian Vahl <florian@flova.de> Signed-off-by: Florian <florian@flova.de>
gbiggs
added a commit
that referenced
this pull request
Nov 25, 2022
* Remove reference to old impementation Signed-off-by: Florian Vahl <florian@flova.de> * Add support for non standard point step sizes Signed-off-by: Florian Vahl <florian@flova.de> * Fix code style Signed-off-by: Florian Vahl <florian@flova.de> * Add test Signed-off-by: Florian <florian@flova.de> Signed-off-by: Florian Vahl <florian@flova.de> Signed-off-by: Florian <florian@flova.de> Signed-off-by: Florian Vahl <florian@flova.de> Signed-off-by: Florian <florian@flova.de> Co-authored-by: Florian Vahl <florian@flova.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197