New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for launching dynamically composable nodes #206
Conversation
Co-Authored-By: sloretz <shane.loretz@gmail.com>
Co-Authored-By: sloretz <shane.loretz@gmail.com>
Co-Authored-By: sloretz <shane.loretz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it another pass, I think it's ready to go.
# Values from message rcl_interfaces/Log | ||
uint8 log_level | ||
# Remap rules | ||
# TODO(sloretz) rcl_interfaces message for remap rules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sloretz that'd be nice indeed :)
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is good to go.
* wip * more work in progress * more work done on the calling conventions section * added context section, still a WIP * updated event sections * event filters * fixup even handler subsection * typos * add subsections about the system description (language agnostic) * Proposal for launching dynamically composable nodes (#206) * Proposal for dynamically composed nodes * allow multiple extra_arguments * Allow node_name and namespace to be empty * Human readable error message * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Assign nodes unique ids, but still forbid duplicates * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Update articles/150_roslaunch.md Co-Authored-By: sloretz <shane.loretz@gmail.com> * Section to list * More generic wording about container processes * namespace -> node_namespace * _launch/ -> ~/_container/ Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Propose ROS 2 launch front-end design hints. (#208) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Adds ROS 2 launch XML format design document (#207) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Update ROS launch documentation (frontend documents) (#247) Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * review fixup Signed-off-by: William Woodall <william@osrfoundation.org> * clarify lifecycle transition due to review comment Signed-off-by: William Woodall <william@osrfoundation.org> * provide rationale for shutdown procedure Signed-off-by: William Woodall <william@osrfoundation.org> * Add launch XML substitution for a packages share directory (#254) * Add launch XML substitution for a packages share directory Rename find-pkg to find-pkg-prefix. Add find-pkg-share substitution for the share directory. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * remove some old rfc's and general cleanup for first merge Signed-off-by: William Woodall <william@osrfoundation.org>
This is a rough draft proposing changes to the roslaunch design document for dynamically composable nodes.