Skip to content

Conversation

fujitatomoya
Copy link
Collaborator

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prints the following.

root@tomoyafujita:~/docker_ws/ros2_colcon# ros2 run examples_rclpy_minimal_publisher publisher_member_function_with_wait_for_all_acked
[INFO] [1743052656.346405897] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 0"
[INFO] [1743052656.822306587] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 1"
[INFO] [1743052657.322247538] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 2"
[INFO] [1743052657.822245921] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 3"
[INFO] [1743052658.322223461] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 4"
[INFO] [1743052658.822131752] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 5"
[INFO] [1743052659.319832563] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 6"
[INFO] [1743052659.822224246] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 7"
[INFO] [1743052660.322310108] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 8"
[INFO] [1743052660.822310312] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 9"
[INFO] [1743052661.319650168] [minimal_publisher_with_wait_for_all_acked]: Waiting for all messages to be acknowledged...
[INFO] [1743052662.328740734] [minimal_publisher_with_wait_for_all_acked]: All messages acknowledged.
[INFO] [1743052662.832233436] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 0"
[INFO] [1743052663.332259226] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 1"
[INFO] [1743052663.832200520] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 2"
[INFO] [1743052664.332234549] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 3"
[INFO] [1743052664.832191564] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 4"
...<snip>

@fujitatomoya
Copy link
Collaborator Author

@ahcorde can you review this when you have time?

@fujitatomoya fujitatomoya self-assigned this Mar 27, 2025
@fujitatomoya fujitatomoya requested a review from ahcorde March 27, 2025 05:24
@ahcorde
Copy link
Contributor

ahcorde commented Mar 27, 2025

Pulls: #407
Gist: https://gist.githubusercontent.com/ahcorde/750d40abd45799899bc5abe78f663a1c/raw/950372b71b467b26b46deca0fa8023f670a4edf0/ros2.repos
BUILD args: --packages-up-to examples_rclpy_minimal_publisher --packages-above-and-dependencies examples_rclpy_minimal_publisher
TEST args: --packages-select examples_rclpy_minimal_publisher --packages-above examples_rclpy_minimal_publisher
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15495

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

on windows, rmw_cyclonedds is failing with,

C:\ci\ws\src\ros2\rmw_cyclonedds\rmw_cyclonedds_cpp\src\bytewise.hpp(32,12): error C2371: 'byte': redefinition; different basic types (compiling source file C:\ci\ws\src\ros2\rmw_cyclonedds\rmw_cyclonedds_cpp\src\rmw_node.cpp) [C:\ci\ws\build\rmw_cyclonedds_cpp\rmw_cyclonedds_cpp.vcxproj]

i am not sure why this is happening, before diving into the details i would like to retry just once again.

  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Mar 27, 2025

@fujitatomoya This PR ros2/rcutils#492 should fix the windows regression

@ahcorde ahcorde merged commit bea0186 into rolling Mar 27, 2025
2 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Mar 27, 2025

Windows warning is unrelated

@ahcorde ahcorde deleted the fujitatomoya/rclpy_minimal_publisher_acked branch March 27, 2025 22:27
@fujitatomoya
Copy link
Collaborator Author

i am writing documentation about this. this feature is supported from Humble, to keep the documentation consistent between all released distro, i would like to backport this example.

@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble jazzy

Copy link
Contributor

mergify bot commented Mar 28, 2025

backport humble jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 28, 2025
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
(cherry picked from commit bea0186)
mergify bot pushed a commit that referenced this pull request Mar 28, 2025
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
(cherry picked from commit bea0186)
@Yadunund
Copy link
Member

Looks like this PR introduced a flake8 regression. The CI job reported a success despite the logs having an error: https://ci.ros2.org/job/ci_linux/22905/console. This also happened in ros2/rosbag2#1946 (comment).

@fujitatomoya
Copy link
Collaborator Author

@Yadunund this PR does not touch anything ros2/demos#712 trying to fix???

maybe #407 (comment) should have been posted on ros2/demos#711?

@Yadunund
Copy link
Member

@fujitatomoya a CI job I ran for a different PR flagged a test error for examples_rclpy_minimal_publisher: https://ci.ros2.org/job/ci_linux/22914/testReport/junit/examples_rclpy_minimal_publisher.topics.minimal_publisher.test/test_flake8/test_flake8/

And when i look at the console logs for the job Alex ran above, I do see the flake8 failure but somehow the CI job was reported as success: https://ci.ros2.org/job/ci_linux/22905/console

@fujitatomoya
Copy link
Collaborator Author

@Yadunund

Ah, sorry i was mixed up, my bad.

now i see flake8 error with backports. i will fix it up.

ahcorde pushed a commit that referenced this pull request Mar 28, 2025
) (#409)

* add publisher_member_function_with_wait_for_all_acked.py. (#407)

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
(cherry picked from commit bea0186)
ahcorde pushed a commit that referenced this pull request Mar 28, 2025
) (#408)

* add publisher_member_function_with_wait_for_all_acked.py. (#407)

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
(cherry picked from commit bea0186)
@fujitatomoya
Copy link
Collaborator Author

@ahcorde thank you very much for taking care of this and backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants