-
Notifications
You must be signed in to change notification settings - Fork 339
add publisher_member_function_with_wait_for_all_acked.py. #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prints the following.
root@tomoyafujita:~/docker_ws/ros2_colcon# ros2 run examples_rclpy_minimal_publisher publisher_member_function_with_wait_for_all_acked
[INFO] [1743052656.346405897] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 0"
[INFO] [1743052656.822306587] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 1"
[INFO] [1743052657.322247538] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 2"
[INFO] [1743052657.822245921] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 3"
[INFO] [1743052658.322223461] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 4"
[INFO] [1743052658.822131752] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 5"
[INFO] [1743052659.319832563] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 6"
[INFO] [1743052659.822224246] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 7"
[INFO] [1743052660.322310108] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 8"
[INFO] [1743052660.822310312] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 9"
[INFO] [1743052661.319650168] [minimal_publisher_with_wait_for_all_acked]: Waiting for all messages to be acknowledged...
[INFO] [1743052662.328740734] [minimal_publisher_with_wait_for_all_acked]: All messages acknowledged.
[INFO] [1743052662.832233436] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 0"
[INFO] [1743052663.332259226] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 1"
[INFO] [1743052663.832200520] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 2"
[INFO] [1743052664.332234549] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 3"
[INFO] [1743052664.832191564] [minimal_publisher_with_wait_for_all_acked]: Publishing: "Hello World: 4"
...<snip>
@ahcorde can you review this when you have time? |
Pulls: #407 |
on windows, rmw_cyclonedds is failing with, C:\ci\ws\src\ros2\rmw_cyclonedds\rmw_cyclonedds_cpp\src\bytewise.hpp(32,12): error C2371: 'byte': redefinition; different basic types (compiling source file C:\ci\ws\src\ros2\rmw_cyclonedds\rmw_cyclonedds_cpp\src\rmw_node.cpp) [C:\ci\ws\build\rmw_cyclonedds_cpp\rmw_cyclonedds_cpp.vcxproj] i am not sure why this is happening, before diving into the details i would like to retry just once again. |
@fujitatomoya This PR ros2/rcutils#492 should fix the windows regression |
Windows warning is unrelated |
i am writing documentation about this. this feature is supported from Humble, to keep the documentation consistent between all released distro, i would like to backport this example. |
@Mergifyio backport humble jazzy |
✅ Backports have been created
|
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit bea0186)
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit bea0186)
Looks like this PR introduced a flake8 regression. The CI job reported a success despite the logs having an error: https://ci.ros2.org/job/ci_linux/22905/console. This also happened in ros2/rosbag2#1946 (comment). |
@Yadunund this PR does not touch anything ros2/demos#712 trying to fix??? maybe #407 (comment) should have been posted on ros2/demos#711? |
@fujitatomoya a CI job I ran for a different PR flagged a test error for And when i look at the console logs for the job Alex ran above, I do see the flake8 failure but somehow the CI job was reported as success: https://ci.ros2.org/job/ci_linux/22905/console |
Ah, sorry i was mixed up, my bad. now i see flake8 error with backports. i will fix it up. |
@ahcorde thank you very much for taking care of this and backports. |
part of ros2/ros2_documentation#5069
rclpy counterpart of https://github.com/ros2/examples/blob/rolling/rclcpp/topics/minimal_publisher/member_function_with_wait_for_all_acked.cpp