Skip to content

Fix windows failure #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

Fix windows failure #492

merged 2 commits into from
Mar 27, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 27, 2025 •
edited
Loading

This PR #491 is breaking CI when building rmw_cyclonedds_cpp, for example https://ci.ros2.org/view/nightly/job/nightly_win_rel/3379/console

This PR should fix this issue

@ahcorde
Fix windows failure
0aa2386 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from cottsay March 27, 2025 12:57
@ahcorde ahcorde self-assigned this Mar 27, 2025
mjcarroll
mjcarroll reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that we should put in the header or in the implementation?

Seems like it could have a chance to propagate downstream in an unexpected way.

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 27, 2025

Is this something that we should put in the header or in the implementation?

Seems like it could have a chance to propagate downstream in an unexpected way.

I see a similar solution in cyclonedds

these errors are related with the order of inclusion between windows.h and winsock2.h. I'm not really sure we can move this to the implementation

@ahcorde ahcorde requested a review from mjcarroll March 27, 2025 13:30
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 27, 2025 •
edited
Loading

Pulls: #492
Gist: https://gist.githubusercontent.com/ahcorde/31eed4abbc47ca294cda3426353deea5/raw/079078c984171a800a06ddf4fa622b6a88360035/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15497

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@cottsay
Copy link
Member

cottsay commented Mar 27, 2025

Should these defs be moved inside the #if defined _WIN32 || defined __CYGWIN__ block?

@ahcorde
review feedback
df3c8a3 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 27, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 27, 2025
Merged
fujitatomoya
fujitatomoya reviewed Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde thanks for fixing this. honestly i did not have any idea of this, sorry.

@christophebedard christophebedard mentioned this pull request Mar 27, 2025
Merged
@ahcorde ahcorde merged commit 2f3252e into rolling Mar 27, 2025
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/fix_windows_failure branch March 27, 2025 20:41
@ahcorde ahcorde mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@cottsay cottsay Awaiting requested review from cottsay

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @cottsay @mjcarroll @fujitatomoya