Rename spin_once to _spin_once_impl in custom executor#447
Merged
fujitatomoya merged 1 commit intoros2:rollingfrom May 3, 2026
Merged
Rename spin_once to _spin_once_impl in custom executor#447fujitatomoya merged 1 commit intoros2:rollingfrom
fujitatomoya merged 1 commit intoros2:rollingfrom
Conversation
Signed-off-by: Noel Jiménez García <noel.jimenez.gar@gmail.com>
fujitatomoya
approved these changes
May 2, 2026
Collaborator
|
@Noel215 good eye! thanks! |
Collaborator
|
Pulls: #447
|
Collaborator
|
@Mergifyio backport lyrical |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ros2/rclpy#1510, the
spin()method calls_spin_once_impl()instead ofspin_once(), so the method name has to be updated in thecustom_executorTest after applying the changes: