Add chain tutorial python #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing with other filter Signed-off-by: EsipovPA <esipov.p@mail.ru>
ahcorde
requested changes
Nov 4, 2025
doc/Tutorials/Chain-Python.rst
Outdated
| 1. Create a Basic Node | ||
| ~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Let's assume, you've already created an empty ROS package for Python. |
Contributor
There was a problem hiding this comment.
Suggested change
| Let's assume, you've already created an empty ROS package for Python. | |
| Let's assume, you've already created an empty ROS 2 package for Python. |
doc/Tutorials/Chain-Python.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| def main(): |
Contributor
There was a problem hiding this comment.
Suggested change
| def main(): | |
| def main(): |
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: EsipovPA <esipov.p@mail.ru>
…r markup and naming fixes Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Signed-off-by: EsipovPA <esipov.p@mail.ru>
EsipovPA
force-pushed
the
add_chain_tutorial_python
branch
from
a0b61ae to
905c33e
Compare
Contributor
Author
|
Hello @ahcorde! Thanks for review. I've added the changes you've requested. :) |
ahcorde
approved these changes
Nov 5, 2025
Contributor
|
Pulls: #219
|
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit b64e5ef)
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit b64e5ef)
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Signed-off-by: EsipovPA <esipov.p@mail.ru> (cherry picked from commit b64e5ef)
This was referenced Nov 12, 2025
ahcorde
pushed a commit
that referenced
this pull request
Nov 13, 2025
ahcorde
pushed a commit
that referenced
this pull request
Nov 13, 2025
ahcorde
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tutorial for
Chainmessage filter forPython.Added some minor fixes to
Chainfilter forPython.Added minor conceptual and grammatical fixes to the
Chainfilter tutorial forC++.Partially fixes but does not resolve completely: #130.
Is this user-facing behavior change?
Fixes
chain = Chain(other_filter)initialization forPythonDid you use Generative AI?
No, I did not.
Additional Information