-
Notifications
You must be signed in to change notification settings - Fork 85
Add lifecycle node support #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
|
I have a idea to improve it, when we want to use Subscriber for message_filters::Subscriber<sensor_msgs::msg::LaserScan,rclcpp_lifecycle::LifecycleNode> sub_;
// it looks like too longwe can adapt template<class NodeT>
Subscriber(NodeT &node, ...){
node_base_interface_ = node->get_node_base_interface();
}then, we can create subscription by using |
|
@mjcarroll can you rerun CI? @tfoote @Karsten1987 can you re-review and/or approve this PR? I believe it meets all of the requirements Karsten wanted. It's something we're trying to use in Nav2 in order to remove excess This is also something we rely on quite a bit in Nav2. I'd be happy to take on a co-maintainership role on this project as well if that would help for future inquiries. |
|
@ros-pull-request-builder retest this please |
|
Thank you both for the help! Does this need a second maintainer review to be merged? Else, I've reviewed independently and am satisfied with this solution. |
Signed-off-by: zhenpeng ge <zhenpeng.ge@qq.com>
|
@mjcarroll can we get a sync with rolling? |
|
Thank you! |
This is a revival of #37.
The original changeset made by @jcmonteiro has been rebased on the latest code + adapted where necessary, and the feedback left by @Karsten1987 has been addressed.
Let me know if there's anything else that should go in!