Fix unnecessary allocations in executor.cpp #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwecht
force-pushed
the
fix_unnecessary_allocations_in_executor
branch
from
9ed13a9
to
dc1dfdd
Compare
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
cwecht
force-pushed
the
fix_unnecessary_allocations_in_executor
branch
from
dc1dfdd
to
d13f2aa
Compare
mjcarroll
approved these changes
Mar 27, 2023
|
|
The windows test failures are known flakes. |
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 28, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::function will allocate on every call of take_and_do_error_handling (at least with libstdc++ as in this implementation std::function's small buffer can only fit two pointers but most of the time, the lambdas will contain 3 pointers). This impose multiple heap allocations (and deallocations) on every callback.
This comes with the cost of increased binary size. But I suppose it's worth it as this change also enables better/easier inling and avoids indirect function calls through the std::function machinery.