Skip to content

Add get_parameter_or overload returning value or alternative #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

Add get_parameter_or overload returning value or alternative #2973

merged 2 commits into from
Nov 7, 2025

Conversation

@Maverobot
Copy link
Contributor

@Maverobot Maverobot commented Oct 31, 2025

Description

LifecycleNode is missing a get_parameter_or public function, which exists in Node.

Is this user-facing behavior change?

Yes. It makes the behavior of LifecycleNode more consistent with Node.

Did you use Generative AI?

No.

@Maverobot
feat(lifecycle_node): add get_parameter_or overload returning value o…
8ffcf53 
…r alternative

Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
@Maverobot Maverobot force-pushed the add-get-parameter-or-for-lifecyclenode branch from f7aa101 to 8ffcf53 Compare October 31, 2025 20:01
fujitatomoya
fujitatomoya requested changes Nov 1, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is just fine to have this methods in LifecycleNode to keep the consistency with Node under current design.

can you also add the test to make sure this method works?

@Maverobot
test: add tests for get_parameter_or in lifecycle node
384c781 
Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
@Maverobot
Copy link
Contributor Author

Maverobot commented Nov 1, 2025

Adding tests makes total sense. A new test has now been pushed in a separate commit.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 7, 2025

Pulls: #2973
Gist: https://gist.githubusercontent.com/fujitatomoya/26fc70fefbda7756e0caafb9c303746c/raw/dc036209abea296077557d87bdd632b872200090/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp_lifecycle
TEST args: --packages-above rclcpp_lifecycle
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17410

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit eb49444 into ros2:rolling Nov 7, 2025
3 checks passed
@Maverobot Maverobot deleted the add-get-parameter-or-for-lifecyclenode branch November 7, 2025 11:39
@ahcorde
Copy link
Contributor

ahcorde commented Nov 7, 2025

@fujitatomoya do we need to backport this one ?

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 8, 2025

@Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 8, 2025
@Maverobot @mergify
Add get_parameter_or overload returning value or alternative (#2973)
9e5283b 
Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
(cherry picked from commit eb49444)
@mergify mergify bot mentioned this pull request Nov 8, 2025
Merged
mergify bot pushed a commit that referenced this pull request Nov 8, 2025
@Maverobot @mergify
Add get_parameter_or overload returning value or alternative (#2973)
b8bf6ff 
Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
(cherry picked from commit eb49444)
@mergify mergify bot mentioned this pull request Nov 8, 2025
Merged
mergify bot pushed a commit that referenced this pull request Nov 8, 2025
@Maverobot @mergify
Add get_parameter_or overload returning value or alternative (#2973)
6ca745f 
Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
(cherry picked from commit eb49444)
@mergify mergify bot mentioned this pull request Nov 8, 2025
Merged
ahcorde pushed a commit that referenced this pull request Nov 10, 2025
@mergify @Maverobot
Add get_parameter_or overload returning value or alternative (#2973) (#…
bda164f 
…2976)

(cherry picked from commit eb49444)

Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
Co-authored-by: Zheng Qu <quzhengrobot@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 10, 2025
@mergify @Maverobot
Add get_parameter_or overload returning value or alternative (#2973) (#…
1332331 
…2977)

(cherry picked from commit eb49444)

Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
Co-authored-by: Zheng Qu <quzhengrobot@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 10, 2025
@mergify @Maverobot
Add get_parameter_or overload returning value or alternative (#2973) (#…
e69382c 
…2978)

(cherry picked from commit eb49444)

Signed-off-by: Zheng Qu <quzhengrobot@gmail.com>
Co-authored-by: Zheng Qu <quzhengrobot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maverobot @fujitatomoya @ahcorde