Add rcl_node_get_fully_qualified_name #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RARvolt <rarvolt@gmail.com>
tfoote
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
This looks good to me pending resolution of comments in ros2/rcl#369
|
@rarvolt I merged this into a branch and ran the CI on it and it looks like there's one small linter error. Could you resolve the linter error and rebase this to get the latest changes? Also when you rebase please use the signed off by. We're in the process of rolling out a DCO on ROS2 repositories. Merged branch CI
Note to self. trigger parameters here for a rebuild after rebase https://ci.ros2.org/job/ci_launcher/3000/parameters/ |
mjcarroll
added
in progress
|
@rarvolt I'm moving this back to "In Progress" until you have rebased with signed off commits as well as addressed the CI issues. Please move it back to "In Review" when you are ready for it to be reviewed again. |
* logging, remove_const before comparison This change removes the const value from the logger before comparing with std::is_same. Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * logging template, replace remove_const by remove_cv Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * Append typename Located after compiling rclcpp_action from source Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
* Rename action state transitions Now using active verbs as described in the design doc: http://design.ros2.org/articles/actions.html#goal-states Connects to ros2/rcl#399. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
…os2#678) * Created function to generate exception objects Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Created function to generate exception objects Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Fixed typo Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Fixed typo Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Throw exceptions not created by ret Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Throw exceptions not created by ret Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * convert throw_from_rcl_error to use from_rcl_error Mostly just a convenience function Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Updated .gitignore Please ignore Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Re-ordered functions to allow compilation Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * Revert "Updated .gitignore" This reverts commit bee0ee1. Signed-off-by: Jacob Hassold <jhassold@dcscorp.com> * restore .gitignore to original state Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * oops, actually restore .gitignore Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* overload for node interfaces Signed-off-by: Karsten Knese <karsten@openrobotics.org> * remove new line Signed-off-by: Karsten Knese <karsten@openrobotics.org> * overload client for node iterfaces Signed-off-by: Karsten Knese <karsten@openrobotics.org>
* Add method to read timer cancellation Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add improved documentation Add improved and more unit tests Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add missing include Add override for inherited methods Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Addressed review comments Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Fixed dependencies in the utility.hpp/cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add missing documentation for exceptions in utility.hpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add rclcpp namespace to the utility.cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add check for a non-negative nonros_argc value Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Simplify syntax for the return_arguments Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Incorporate Review Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de>
Both, the `Executor::execute_any_executable` and the destructor for the `AnyExecutable` object used by the multithreaded executor, reset the `can_be_taken_from_` flag on a MutuallyExclusive group. This cause the variable to get out of sync and threads to process executables out of sequence. This fix clears the callback group variable of the `AnyExecutable` instance effectively preventing its destructor from modifying the variable at the wrong time. Issue: ros2#702 Signed-off-by: Guillaume Autran <gautran@clearpath.ai>
* in progress broken test_time_source Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * style Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * test undeclared params Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Only get parameter if it is set Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doc fixup Signed-off-by: William Woodall <william@osrfoundation.org> * use override rather than virtual in places Signed-off-by: William Woodall <william@osrfoundation.org> * rename ParameterInfo_t to ParameterInfo and just use struct, no typedef Signed-off-by: William Woodall <william@osrfoundation.org> * add method to access ParameterValue within a Parameter Signed-off-by: William Woodall <william@osrfoundation.org> * enable get<Parameter> and get<ParameterValue> on Parameter class Signed-off-by: William Woodall <william@osrfoundation.org> * avoid const pass by value Signed-off-by: William Woodall <william@osrfoundation.org> * match type of enum in C++ to type used in message definition Signed-off-by: William Woodall <william@osrfoundation.org> * fixup after rebase Signed-off-by: William Woodall <william@osrfoundation.org> * more fixup after rebase Signed-off-by: William Woodall <william@osrfoundation.org> * replace create_parameter with declare_parameter Signed-off-by: William Woodall <william@osrfoundation.org> * provide implementation for templated declare_parameter method Signed-off-by: William Woodall <william@osrfoundation.org> * style Signed-off-by: William Woodall <william@osrfoundation.org> * do not use const reference when it's a primitive (like bool) Signed-off-by: William Woodall <william@osrfoundation.org> * typo Signed-off-by: William Woodall <william@osrfoundation.org> * follow to bool change that wasn't staged Signed-off-by: William Woodall <william@osrfoundation.org> * fixup tests Signed-off-by: William Woodall <william@osrfoundation.org> * added lots of docs, alternative API signatures, and some of the tests Signed-off-by: William Woodall <william@osrfoundation.org> * more tests and associated fixes Signed-off-by: William Woodall <william@osrfoundation.org> * address documentation feedback Signed-off-by: William Woodall <william@osrfoundation.org> * fixup previously added tests Signed-off-by: William Woodall <william@osrfoundation.org> * add tests and fixes for describe_parameter(s) and get_parameter_types Signed-off-by: William Woodall <william@osrfoundation.org> * remove old parameter tests Signed-off-by: William Woodall <william@osrfoundation.org> * use const reference where possible Signed-off-by: William Woodall <william@osrfoundation.org> * address comments Signed-off-by: William Woodall <william@osrfoundation.org> * fix tests for deprecated methods Signed-off-by: William Woodall <william@osrfoundation.org> * address feedback Signed-off-by: William Woodall <william@osrfoundation.org> * significantly improve the reliability of the time_source tests Signed-off-by: William Woodall <william@osrfoundation.org> * uncrustify, cpplint, and cppcheck fixes Signed-off-by: William Woodall <william@osrfoundation.org> * Revert "significantly improve the reliability of the time_source tests" This reverts commit 3ef385d. Signed-off-by: William Woodall <william@osrfoundation.org> * only declare use_sim_time parameter if not already declared Signed-off-by: William Woodall <william@osrfoundation.org> * fixup rclcpp_lifecycle Signed-off-by: William Woodall <william@osrfoundation.org> * fixup tests Signed-off-by: William Woodall <william@osrfoundation.org> * add missing namespace scope which fails on Windows Signed-off-by: William Woodall <william@osrfoundation.org> * extend deprecation warning suppression to support Windows too Signed-off-by: William Woodall <william@osrfoundation.org> * fix compiler warnings and missing visibility macro Signed-off-by: William Woodall <william@osrfoundation.org> * remove commented left over tests Signed-off-by: William Woodall <william@osrfoundation.org> * fix compiler warning on Windows Signed-off-by: William Woodall <william@osrfoundation.org> * suppress deprecation warning on include of file in Windows Signed-off-by: William Woodall <william@osrfoundation.org> * avoid potential loss of data warning converting int64_t to int Signed-off-by: William Woodall <william@osrfoundation.org> * trying to fix more loss of data warnings Signed-off-by: William Woodall <william@osrfoundation.org> * fix test_node Signed-off-by: William Woodall <william@osrfoundation.org> * add option to automatically declare parameters from initial parameters (yaml file) Signed-off-by: William Woodall <william@osrfoundation.org> * remove redundant conditional Signed-off-by: William Woodall <william@osrfoundation.org>
Now supports callbacks for the goal response and result. This also makes it easier to incorporate action clients in composable nodes since we don't have to rely on waiting on futures. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
) * Changed mapped_ring_buffer class to store both shared_ptr or unique_ptr Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Changed the IPM store and take methods Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Changed publish methods to take advantage of the new IPM Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Change how subscriptions handle intraprocess messages Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Modified publish method signatures Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Renamed 'publisher.cpp' and 'subscription.cpp' to 'publisher_base.cpp' and 'subscription_base.cpp' Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Updated lifecycle_publisher publish methods Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ros2#708) * Add assignment of missing parameter-related fields in node options copy constructor. The allow_undeclared_parameters and automatically_declare_initial_parameters fields of the node options class were not assigned in the assignment operator, resulting in an incorrect copy of the node options object, which also indirectly affects the copy constructor. Signed-off-by: Michael Jeronimo <michael.jeronimo@intel.com> * Run linters
* Fix uninitialized bool in clock.cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Fixup includes of clock.hpp/cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add documentation for exceptions to clock.hpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Adjust function signature of getters of clock.hpp/cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Remove raw pointers Clock::create_jump_callback Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Remove unnecessary rclcpp namespace reference from clock.cpp Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Change exception to bad_alloc on JumpHandler allocation failure Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Fix missing nullptr check in Clock::on_time_jump Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add JumpHandler::callback types Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Add warning for lifetime of Clock and JumpHandler Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Incorporate review Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de> * Incorporate review Signed-off-by: Dmitrij Dorezyuk <dmitrij.dorezyuk@hotmail.de>
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ros2/rcl#255